对 FBOSS 代码变更进行多维并行审查,输出可靠性、架构与测试问题建议。
该技能材料表现为开源的 prompt-only 审查提示,无需密钥、未声明远程端点,也未包含可执行安装步骤;整体风险较低。主要留意点在于其 README 会引导宿主代理读取本地 diff/参考文件并可能调用其他工具,但这更像使用流程说明而非技能自身的直接权限。
材料明确标注无需密钥或环境变量,未见要求 API token、账号凭证或长期敏感配置,因此凭证泄露与滥用面较小。
未声明任何远程端点,且系统检查项标记为 prompt-only;README 虽提到可通过其他工具获取 Phabricator diff 详情,但该技能本身未定义外发目标或直接联网逻辑。
作为 prompt-only 技能,材料中未包含脚本、二进制、安装命令或本机执行载荷。README 提及 `sl status`、`sl diff` 与工具调用属于建议的审查流程,不等同于技能自带代码执行能力。
技能目标是审查 FBOSS diff,说明中会使用变更内容及若干参考模式文件,但材料未声明直接读写文件、批量采集用户数据或申请超出代码审查所需的数据范围。
来源为 GitHub 上可审计的开源仓库,这明显降低了供应链风险;但许可证未声明、社区采用度显示为 0 star、维护状态未知,且当前材料仅能确认仓库存在,仍建议在接入前核对具体 skill 文件与仓库关系及最近更新情况。
复制安装指令,让 AI 自动完成配置 · 推荐新手
请帮我安装 askskill 上的 "fboss-review" 技能: 1. 下载 https://raw.githubusercontent.com/facebook/fboss/main/fboss/skills/fboss-review/SKILL.md 2. 保存为 ~/.claude/skills/fboss-review/SKILL.md 3. 装好后重载技能,告诉我可以用了
请审查这组 FBOSS diff,重点检查可靠性、静默失败风险、agent 架构影响、SAI/SDK 兼容性,以及测试覆盖是否充分。请按严重程度列出发现和修复建议,不要自动发布评论。
一份分级代码审查结果,包含问题说明、潜在影响与修复建议。
分析这次 FBOSS 配置与平台相关改动,关注 platform/config、FSDB/thrift_cow 交互、跨模块设计影响,以及是否会引入难以观测的故障模式。
针对平台兼容性和系统设计风险的审查清单与改进建议。
请从工程质量和测试质量角度审查这组 FBOSS diff,指出缺失的单元测试、集成测试和回归测试场景,并说明每项测试为何必要。
一份聚焦测试缺口的审查结果,附带建议补充的测试方案。
Multi-reviewer code review for FBOSS diffs. Subsumes general review (/review-diff functionality) plus FBOSS-specific domain expertise.
Currently fboss/ only. TODO: extend to configerator/source/neteng/fboss, neteng/netcastle, neteng/fboss.
All findings are shown to the user only. Never post to Phabricator automatically.
sl status and sl diff to get changed filesmcp__plugin_meta_mux__get_phabricator_diff_detailsagent/, SwSwitch, -> Agent Reviewer (#6)在 FBOSS 代码开发中自动检查规范、架构误用与测试遗漏。
Debug FBOSS AgentHwTest failures - build, run, analyze logs, crash debug, vendor diag shell, hypothesis-driven debugging. Use when running sai_agent_hw_test or multi_switch_agent_hw_test and investigating test failures.
HwSwitchfsdb/, thrift_cow/ -> FSDB/thrift_cow Reviewer (#7)platform/, config, sensor/fan -> Platform Reviewer (#8)sai/, hw/sai/, SDK -> SAI/SDK Reviewer (#9)Use Agent tool (sonnet model) to dispatch all applicable reviewers simultaneously:
references/generic-reviewers.md.../fboss-code-standards/references/<area>-patterns.md.| # | Reviewer | Focus | Patterns File |
|---|---|---|---|
| 1 | Reliability | Error handling, RAII, logging, timeout/retry, graceful degradation | - |
| 2 | Engineering / Performance | Algorithmic complexity, unnecessary copies, lock contention, modern C++ | - |
| 3 | Code Quality | Readability, modularity, duplication, API design | ../fboss-code-standards/references/general-patterns.md |
| 4 | Summary & Test Plan | Title accuracy, summary completeness, test plan adequacy, diff coherence | - |
| 5 | Silent Failure Finder | Logic errors, lossy conversions, race conditions, silent data loss | - |
| 6 | Agent Architecture | Mono/multi-switch, state management, warmboot, HwSwitch/SwSwitch boundary | ../fboss-code-standards/references/agent-patterns.md |
| 7 | FSDB & thrift_cow | State/Stats duality, COW node safety, subscriptions, build time | ../fboss-code-standards/references/thrift-cow-fsdb-patterns.md |
| 8 | Platform & Config | Platform services, JSON configs, startup order, OSS sync | ../fboss-code-standards/references/platform-config-patterns.md |
| 9 | SAI/SDK Integration | SAI API usage, object lifecycle, vendor SDK compat, attributes | ../fboss-code-standards/references/sai-sdk-patterns.md |
| 10 | Testing Standards | Coverage, naming, fixtures, NSDB impact, HW test patterns | ../fboss-code-standards/references/testing-patterns.md |
| 11 | FBOSS Architect | Cross-cutting design: layering, state derivability, abstraction, code org, infra reuse | references/fboss-specific-reviewers.md |
Dispatch a single verifier agent (loads references/verifier.md) to:
Output a structured report:
| File:Line | Reviewer | Severity | Issue | Confidence |
|-----------|----------|----------|-------|------------|
Never post findings to Phabricator.
| Topic | Action |
|---|---|
| Generic reviewer personas | Read references/generic-reviewers.md |
| Verification/dedup logic | Read references/verifier.md |
| FBOSS-specific reviewer personas | Read references/fboss-specific-reviewers.md |
…